Conversation
86f94af added Rocky Linux as a recognized distro and thus the script sets up the repo[0]. However the repo doesn't currently contain the required packages, and thus the installation fails. Rocky being fully compatible with RHEL, using its repo leads to a working installation. This aligns with the current advice from Rocky's own docs[1]. Fixes docker#264 docker#373 docker#468 docker#469 [0]: https://download.docker.com/linux/rocky/ [1]: https://docs.rockylinux.org/10/gemstones/containers/docker/ Signed-off-by: Bastien Traverse <neitsab@esrevart.net>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
|
I'm not sure we should do this; we deliberately don't handle most derivatives; The plan is to provide add packages for Rocky, but not all are available yet, so wondering if we should either leave the script as-is, or adding a warning ( + delay?) to allow the user to cancel the script. Any thoughts, @vvoland ? |
|
TBF this is just a workaround so as not to leave the current situation broken; IMO the script had better state Rocky was unsupported until the repo was effectively setup, and only then 86f94af would have made sense. I drafted this PR because the replies to my comment on this commit invited to do so, but it is definitely a not-ideal workaround.
This is indeed the root cause and the first issue I wanted to report, but I couldn't find where to do do so (my question below the aforementioned commit didn't get a reply). It would indeed make more a lot more sense to finish building up the packages if that's planned/in doing and then have 86f94af. Leaving the script as-is results in a less-than-satisfying user experience:
That's basically me yesterday, and might generate a bit of useless fuss. |
2 participants
86f94af added Rocky Linux as a recognized distro and thus the script sets up the repo0. However the repo doesn't currently contain the required packages, and thus the installation fails.
Rocky being fully compatible with RHEL, using its repo leads to a working installation. This aligns with the current advice from Rocky's own docs1.
Fixes #264 #373 #468 #469
- What I did
Add a test changing the value of
$repo_file_urlwhen rocky is detected to use rhel repo instead.- How I did it
Thinking a bit and writing as much
- How to verify it
By reading the code?
- Description for the changelog
install: improve Rocky Linux support
- A picture of a cute animal (not mandatory but encouraged)